Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: --no-watch flag, add watch: true to configs #6

Merged
merged 1 commit into from
Apr 6, 2019

Conversation

shellscape
Copy link
Owner

This PR contains:

  • bugfix
  • feature
  • refactor
  • tests
  • documentation
  • metadata

Breaking Changes?

  • yes
  • no

There is potential for breakage in edge cases if users were counting on webpack-serve failing to add the watch: true property to configs.

Please Describe Your Changes

Fixes #5. Adds watch: true to the first config in a webpack configuration file. The --no-watch flag has been added to prevent that behavior for users who wish to manually setup watching, or for users which need to make use of watchOptions.

@pearofducks please review

Sorry, something went wrong.

Copy link

@pearofducks pearofducks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shellscape shellscape merged commit 409b714 into master Apr 6, 2019
@shellscape shellscape deleted the feat/watch branch April 6, 2019 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'watch' needed in the target webpack config - not mentioned
2 participants