From 7e52fe6d828c3c5d6bb30c7e96a0f708a910132f Mon Sep 17 00:00:00 2001 From: Wiktor Kwapisiewicz Date: Tue, 10 Oct 2023 14:00:16 +0200 Subject: [PATCH 1/3] Fix clippy error indicating error in implementation --- openssl/src/bn.rs | 2 +- openssl/src/x509/mod.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/openssl/src/bn.rs b/openssl/src/bn.rs index c75fac1d70..a67d0807aa 100644 --- a/openssl/src/bn.rs +++ b/openssl/src/bn.rs @@ -1229,7 +1229,7 @@ impl Ord for BigNumRef { impl PartialOrd for BigNum { fn partial_cmp(&self, oth: &BigNum) -> Option { - self.deref().partial_cmp(oth.deref()) + Some(self.cmp(oth)) } } diff --git a/openssl/src/x509/mod.rs b/openssl/src/x509/mod.rs index d211006b78..97242ff4d8 100644 --- a/openssl/src/x509/mod.rs +++ b/openssl/src/x509/mod.rs @@ -832,7 +832,7 @@ impl Ord for X509 { impl PartialOrd for X509 { fn partial_cmp(&self, other: &Self) -> Option { - X509Ref::partial_cmp(self, other) + Some(self.cmp(other)) } } From 0773149c60436ed01559dee161de58eaf7ca0019 Mon Sep 17 00:00:00 2001 From: Wiktor Kwapisiewicz Date: Tue, 10 Oct 2023 14:00:38 +0200 Subject: [PATCH 2/3] Upgrade ctest2 to mitigate `mem::forget` warnings --- systest/Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/systest/Cargo.toml b/systest/Cargo.toml index 97a5405b0e..d1e55ac3f2 100644 --- a/systest/Cargo.toml +++ b/systest/Cargo.toml @@ -9,7 +9,7 @@ libc = "0.2" openssl-sys = { path = "../openssl-sys" } [build-dependencies] -ctest2 = "0.4" +ctest2 = "0.4.7" [features] vendored = ['openssl-sys/vendored'] From 32734b756a9cbf7c3312dd14a27a1046e010e528 Mon Sep 17 00:00:00 2001 From: Wiktor Kwapisiewicz Date: Wed, 11 Oct 2023 12:27:35 +0200 Subject: [PATCH 3/3] Fix `hostent` re-export warning by explicitly re-exporting only `c_int` --- openssl-sys/src/lib.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openssl-sys/src/lib.rs b/openssl-sys/src/lib.rs index 784b7637e1..0e23386fd3 100644 --- a/openssl-sys/src/lib.rs +++ b/openssl-sys/src/lib.rs @@ -11,7 +11,7 @@ #![recursion_limit = "128"] // configure fixed limit across all rust versions extern crate libc; -pub use libc::*; +pub use libc::c_int; #[cfg(feature = "unstable_boringssl")] extern crate bssl_sys;