Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reliability of some tests #1852

Merged
merged 1 commit into from Mar 23, 2023
Merged

Improve reliability of some tests #1852

merged 1 commit into from Mar 23, 2023

Conversation

smoelius
Copy link
Contributor

This PR proposes the following changes to the tests:

  • Add CALLED_BACK flags in several places to ensure callbacks are actually executed.
  • Call unwrap on the result of the set_ssl_context call to ensure the call was successful.
  • Rename connector_no_hostname_can_disable_verify to connector_can_disable_verify, and furthermore:
    • remove the call to verify_hostname (unnecessary since verification of the server's certificate is disabled);
    • change the connected-to hostname from foobar to fizzbuzz to emphasize that it is not checked.

@sfackler sfackler merged commit 690eeb2 into sfackler:master Mar 23, 2023
51 checks passed
@sfackler
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants