-
Notifications
You must be signed in to change notification settings - Fork 346
Add Url::make_relative() as the inverse of Url::join() #668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The clippy failures are all unrelated to this PR. I can submit another PR for them if you agree that all those should be fixed, or let me know which of the lints you'd like to disable (personally I'm not a fan of |
Yup, sorry about the clippy failures. Another PR would be nice, though a separate commit in this PR is also fine. I think we should fix all of them except the ones about the unit errors, because those would break backwards compatibility. |
1218ba8
to
92e21e0
Compare
clippy fixes are in #669 |
92e21e0
to
28a7231
Compare
Rebased on top of #669 |
Thanks for this PR. It looks really nice. |
Sure, will add a few tests for that later or tomorrow! Thanks for the review |
Added tests for the 4 possible error cases. |
☔ The latest upstream changes (presumably #703) made this pull request unmergeable. Please resolve the merge conflicts. |
This creates a relative URL from a base URL and another absolute URL. Fixes servo#666
And rebased for the merge conflicts. @valenting anything else missing here? |
This creates a relative URL from a base URL and another absolute URL.
Fixes #666