Serialize rcdom iteratively #372
Merged
+133
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo r+ |
|
📌 Commit 19eba5d has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Apr 26, 2019
Serialize rcdom iteratively Fixes #371.
|
💔 Test failed - checks-travis |
|
@bors-servo r=Manishearth |
|
📌 Commit ebfffde has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Apr 26, 2019
Serialize rcdom iteratively Fixes #371.
|
💔 Test failed - checks-travis |
|
Maybe +cargo bench --all
Updating crates.io index
error: failed to select a version for the requirement `markup5ever = "^0.7"`
candidate versions found which didn't match: 0.8.0
location searched: /home/travis/build/servo/html5ever/markup5ever
required by package `html5ever v0.22.7 (/home/travis/build/servo/html5ever/html5ever)`
The command "scripts/travis-build.sh" exited with 101. |
|
@bors-servo r=manishearth |
|
📌 Commit 014b3ce has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Apr 27, 2019
Serialize rcdom iteratively Fixes #371.
|
☀️ Test successful - checks-travis |
bors-servo
pushed a commit
that referenced
this pull request
May 3, 2019
Expose public Node constructor. Since #372 there is a private field in Node that prevents constructing them manually. If we want to support that, we need to expose the constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #371.