Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

static member access for parameters of concrete types #291

Merged
merged 2 commits into from
Jan 8, 2022
Merged

static member access for parameters of concrete types #291

merged 2 commits into from
Jan 8, 2022

Conversation

skomis-mm
Copy link
Contributor

fixes #287

tsimbalar
tsimbalar approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@tsimbalar tsimbalar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

It's been a while, and I can't really remember why we had put that restriction in the first place 🤔

also, sorry for not being more active anymore 😬 I'm still following from far, but haven't been working in .NET in the last 3 years

@skomis-mm
Copy link
Contributor Author

Thanks, @tsimbalar 👍 Hope you are going well on other projects.
Although miss your contributions :P

@skomis-mm skomis-mm merged commit b46a5f9 into serilog:dev Jan 8, 2022
@skomis-mm skomis-mm deleted the staticMemberAccess branch January 8, 2022 08:04
@nblumhardt nblumhardt mentioned this pull request Jan 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsimbalar tsimbalar tsimbalar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Static member access doesn't work for concrete type parameters
2 participants
@skomis-mm @tsimbalar