NU1605 fix for .net core clients #218
Conversation
|
Nice find! Looks like the fix, fingers crossed. |
| @@ -15,23 +15,30 @@ | |||
| <PackageId>Serilog.Settings.Configuration</PackageId> | |||
| <PackageTags>serilog;json</PackageTags> | |||
| <PackageIcon>icon.png</PackageIcon> | |||
| <PackageProjectUrl>https://github.com/serilog/serilog-settings-configuration</PackageProjectUrl> | |||
| <PackageProjectUrl>https://serilog.net/</PackageProjectUrl> | |||
There was a problem hiding this comment.
nit : this changes the link that the Nuget page points to :
https://www.nuget.org/packages/Serilog.Settings.Configuration/3.1.1-dev-00228
Not sure if it's a big deal, but if people is looking for docs specific to that package it becomes a little bit harder to find, what do you thing ?
There was a problem hiding this comment.
@tsimbalar , ah, right, a bad copy/paste from Serilog repository, will fix in next change
There was a problem hiding this comment.
I've been going on the assumption that "source repository" is the GitHub link, while "project" is more informational, but either way seems fine to me :-)
There was a problem hiding this comment.
@nblumhardt you are right. But unfortunately "source repository" is not shown in VS nor in the linqpad 😄 :
Notes: the issue occurs when
RuntimeIdentifierspecified on publish/restore fornetstandard2.xproject withMicrosoft.NETCore.Targets=1.1.xresolved by nuget dependency resolution. This change force to use3.0.0as suggested in docs and related issue.Cosmetic adjustments: