Update to Serilog 4 including TFMs and toolchain #40
+508
−584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
Numpsy
reviewed
Jul 2, 2024
| - Build.ps1 | ||
| - assets/ | ||
| - test/Serilog.Formatting.Compact.Reader.Tests/ | ||
| - path: artifacts/Serilog.*.nupkg |
There was a problem hiding this comment.
Looks like it's creating a snupkg but not pushing it into the AppVeyor CI artifacts?
There was a problem hiding this comment.
Thanks! Nice spotting.
I'm planning to kick off a revamp of a lot of the build and publishing bits once we're through the last package updates, with the goal of using one centrally managed set of scripts across all of the projects (and likely switching to GitHub Actions to streamline secrets management).
I thought about doing it on this first pass but it left the scope a bit too wide to confidently plough through - it'll be nice to smooth over all of these inconsistencies soon, though 😅
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops pre-netstandard2.0 targets, otherwise nonbreaking.