feat: platform specific open options for streams #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it a bit easier to have platform specific open options. I'm in love with the solution but it doesn't seem possible to filter the generic via a typecheck and have it apply to the open options. So casting the open options is the only recouse I've figured out.
| import { ErrorCallback, OpenOptions, SerialPortStream } from '@serialport/stream' | ||
| import { autoDetect, AutoDetectTypes } from '@serialport/bindings-cpp' | ||
| import { ErrorCallback, OpenOptions, SerialPortStream, StreamOptions } from '@serialport/stream' | ||
| import { autoDetect, AutoDetectTypes, OpenOptionsFromBinding } from '@serialport/bindings-cpp' | ||
|
|
||
| const DetectedBinding = autoDetect() |
There was a problem hiding this comment.
Since autoDetect returns a non-discriminating union (AutoDetectTypes), I think that is why the type assertion is needed from DetectedBinding later. Is it possible to brand each binding interface to help with this detection narrowing?
There was a problem hiding this comment.
I think I understand - let me try it out
There was a problem hiding this comment.
Branded types are rad but not helping in this case. I'm positive we'll revisit this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it a bit easier to have platform specific open options. I'm in love with the solution but it doesn't seem possible to filter the generic via a typecheck and have it apply to the constructor options on a serialport stream. So casting the open options is the only recourse I've figured out.