Delete tombstones of the __private
module
#2547
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are previous names of the
__private
module — firstserde::export
thenserde::private
thenserde::__private
— in all cases markeddoc(hidden)
and documented as not public API. Leaving a tombstone made rustc give a better diagnostic "module is private" rather than "unresolved import". But the rename to__private
was 2.5 years ago in dd1f4b4 so it's unlikely anyone is still benefiting from the tombstone at this point.