Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error span for attribute / data kind mismatches #2536

Merged
merged 1 commit into from Jul 27, 2023
Merged

Update error span for attribute / data kind mismatches #2536

merged 1 commit into from Jul 27, 2023

Conversation

jplatte
Copy link
Contributor

@jplatte jplatte commented Jul 27, 2023

Follow-up to #1695 (comment).

There are a few more in line 770 and below, but there it wasn't quite as clear what to set the span to.

dtolnay
dtolnay approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

test_suite/tests/ui/default-attribute/enum_path.stderr Outdated Show resolved Hide resolved
@jplatte jplatte requested a review from dtolnay July 27, 2023 17:48
dtolnay
dtolnay approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you.

@dtolnay dtolnay merged commit 7a4335d into serde-rs:master Jul 27, 2023
21 checks passed
@jplatte jplatte deleted the jplatte/error-span branch July 27, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jplatte @dtolnay