Move serde_test out to serde-rs/test #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mingun
reviewed
Jul 26, 2023
Comment on lines
+8
to
+10
|
|
||
| [patch.crates-io] | ||
| serde = { path = "serde" } |
There was a problem hiding this comment.
This PR breaks any attempts to experiment with changing serde public API. I think, it is due to this line. Is it possible to do without it? What is it for?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a good reason for
serdeandserde_deriveto be versioned together, but no reason forserde_test, other than the historical effect of this being originally private code that was extracted out of serde's test suite to be published.I generated serde-rs/test@0a45bbf using
git filter-repo --path serde_testat 6140b6f.Since #2441, serde's test suite no longer relies on nonpublic APIs of
serde_test.