Fix incorrect count of fields passed to tuple deserialization methods #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This count should mean the number of fields expected in the serialized form, so if some fields are skipped, they shouldn't be counted Methods affected: - Deserializer::deserialize_tuple - Deserializer::deserialize_tuple_struct - VariantAccess::tuple_variant
oli-obk
approved these changes
May 30, 2023
crapStone
added a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Jul 7, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [serde](https://serde.rs) ([source](https://github.com/serde-rs/serde)) | dependencies | patch | `1.0.164` -> `1.0.167` | --- ### Release Notes <details> <summary>serde-rs/serde (serde)</summary> ### [`v1.0.167`](https://github.com/serde-rs/serde/releases/tag/v1.0.167) [Compare Source](serde-rs/serde@v1.0.166...v1.0.167) - Add serialize and deserialize impls for `RangeFrom` and `RangeTo` ([#​2471](serde-rs/serde#2471), thanks [@​tbu-](https://github.com/tbu-)) ### [`v1.0.166`](https://github.com/serde-rs/serde/releases/tag/v1.0.166) [Compare Source](serde-rs/serde@v1.0.165...v1.0.166) - Add `no-alloc` category to crates.io metadata ### [`v1.0.165`](https://github.com/serde-rs/serde/releases/tag/v1.0.165) [Compare Source](serde-rs/serde@v1.0.164...v1.0.165) - Fix incorrect count of fields passed to tuple deserialization methods when using `serde(skip_deserializing)` attributes ([#​2466](serde-rs/serde#2466), thanks [@​Mingun](https://github.com/Mingun)) - Fix `-Zminimal-versions` build </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4wLjAiLCJ1cGRhdGVkSW5WZXIiOiIzNi4xLjExIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Co-authored-by: crapStone <crapstone01@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1953 Reviewed-by: crapStone <crapstone01@gmail.com> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This count should mean the number of fields expected in the serialized form, so if some fields are skipped, they shouldn't be counted.
Methods affected:
After this PR number of fields passed to deserializer methods will be the same as number, passed to the serializer methods.
I didn't include tests in that PR, because correct test suite should cover all possible situations, and many of them have certain problems. I plan to include a full testsuite in my upcoming PR for fixing #2105.
Right now you can see what changed in the generated code by running the following commands:
test_suite/testsfolder and change its extension to.rs...\serde\test_suite> cargo expand --all-features --test skip