Simplify code for generation of struct deserializers #2444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
approved these changes
Jun 26, 2023
…_struct_visitor`
…in both cases When !cattrs.has_flatten() all fields is !field.attrs.flatten() Co-authored-by: Oliver Schneider <oli-obk@users.noreply.github.com>
…is same in both arms
dtolnay
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Thanks! This is a great cleanup. And thanks Oli for the review.
#2444 looks good (modulo a comment). It is a pure refactoring in well-reviewable individual commits. I checked that it does not change behaviour. The main part that needs your review is the actual change (moving from multiple somewhat connected boolish or option arguments to a single enum that separates all the different cases into explicit variants)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first 7 commits of this PR eliminates various duplications from the code, making it more easely to understand, as I hope.
The last 3 commits makes more obvious which code is generated for different combinations of arguments. Because not all combinations are possible, after the changes impossible variants are not representable in the code.