Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make derived serializer/deserializer internals doc(hidden) #2426

Merged
merged 1 commit into from Apr 11, 2023

Conversation

compiler-errors
Copy link
Contributor

@compiler-errors compiler-errors commented Apr 11, 2023

This adds a handful of #[doc(hidden)] attrs to make sure we don't document all of the derive serialization/deserialization internals when we use --document-private-items, since rustdoc now documents things inside of const _: () = { /* ... */ }; blocks due to rust-lang/rust#104889 (which was reverted in rust-lang/rust#107083, and later re-applied in rust-lang/rust#107000 -- so the behavior is only present on 1.69 and above).

Before:

image

After:

image

Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit a80d830 into serde-rs:master Apr 11, 2023
19 checks passed
crapStone added a commit to Calciumdibromid/CaBr2 that referenced this pull request Apr 11, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [serde](https://serde.rs) ([source](https://github.com/serde-rs/serde)) | dependencies | patch | `1.0.159` -> `1.0.160` |

---

### Release Notes

<details>
<summary>serde-rs/serde</summary>

### [`v1.0.160`](https://github.com/serde-rs/serde/releases/tag/v1.0.160)

[Compare Source](serde-rs/serde@v1.0.159...v1.0.160)

-   Make derived serializer/deserializer internals `doc(hidden)` ([#&#8203;2426](serde-rs/serde#2426), thanks [@&#8203;compiler-errors](https://github.com/compiler-errors))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40MC4yIiwidXBkYXRlZEluVmVyIjoiMzUuNDAuMiJ9-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Co-authored-by: crapStone <crapstone01@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1859
Reviewed-by: crapStone <crapstone@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
mTsBucy1 added a commit to mTsBucy1/tokio-contrib-fork that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants