[CLNP-2908] Typescript error fix for hooks #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed type errors when 'strictNullChecks' is 'true'.
Fixed type errors when 'strictNullChecks' is 'true'.
Fixed type errors when 'strictNullChecks' is 'true'. 슬랙으로 공유드린 내용 제외하고, 수정해도 특별히 문제 없을 만한 부분 우선 수정하였습니다.
프로젝트 전체 strictNullChecks 는 true로 두고 strictNullChecks 관련 에러가 수정되지 않은 아래 폴더는 strictNullChecks 하지 않도록 구성 하였습니다. src/modules src/lib src/hooks
modules에서 고객사에게 영향이 없을것 같다고 예상되는 에러들 위주로 수정 하였습니다.
bang9
reviewed
Apr 22, 2024
bang9
reviewed
Apr 22, 2024
chrisallo
changed the base branch from
feat/v3/CLNP-2496-strict-typescript
to
main
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bang9
reviewed
May 2, 2024
| audioFileUrl = '', | ||
| }: UseVoicePlayerProps): UseVoicePlayerContext => { | ||
| const [groupKey] = useState<string>(generateGroupKey(channelUrl, key)); | ||
| const groupKey = generateGroupKey(channelUrl, key); |
There was a problem hiding this comment.
note: state 로 관리하면 url,key 업데이트를 해주는 로직이 필요, 일반 string 사용하도록 수정
…bird/sendbird-uikit-react into feat/clnp-2908-ts-fix-hooks
bang9
reviewed
May 2, 2024
bang9
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: CLNP-2908