Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerelease check improvements #244

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

severn-everett
Copy link
Contributor

Split out check of alphanumeric prerelease into its own function and improved check of trailing characters.

This fixes #234

@severn-everett
Copy link
Contributor Author

I would once again be glad to accept any suggestions for "unconventional" version strings to check this code further

@piotrooo piotrooo added the bug Something isn't working label Apr 17, 2024
@piotrooo piotrooo merged commit 671d9c6 into semver4j:main Apr 17, 2024
3 checks passed
@severn-everett severn-everett deleted the invalid_prerelease branch April 29, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

version compare error
2 participants