Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion of internal package classes to use static only #240

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

severn-everett
Copy link
Contributor

Internal package classes are now containers of pure functions; Slight refinements of Coerce to directly use pattern-matching string as well as Optional for parsing nullable values

Fixes #239

… refinements of Coerce to directly use pattern-matching string as well as Optional for parsing nullable values
@piotrooo piotrooo assigned piotrooo and severn-everett and unassigned piotrooo Apr 10, 2024
@piotrooo piotrooo added enhancement New feature or request refactor Small task connected with refactor and removed enhancement New feature or request labels Apr 10, 2024
Copy link
Member

@piotrooo piotrooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments; generally, I like the idea of this refactor.

src/main/java/org/semver4j/internal/Modifier.java Outdated Show resolved Hide resolved
src/main/java/org/semver4j/internal/Modifier.java Outdated Show resolved Hide resolved
src/main/java/org/semver4j/internal/Modifier.java Outdated Show resolved Hide resolved
src/main/java/org/semver4j/internal/Modifier.java Outdated Show resolved Hide resolved
src/main/java/org/semver4j/internal/Modifier.java Outdated Show resolved Hide resolved
src/main/java/org/semver4j/internal/Modifier.java Outdated Show resolved Hide resolved
src/main/java/org/semver4j/internal/Modifier.java Outdated Show resolved Hide resolved
src/main/java/org/semver4j/internal/Modifier.java Outdated Show resolved Hide resolved
src/main/java/org/semver4j/internal/Coerce.java Outdated Show resolved Hide resolved
@piotrooo piotrooo merged commit 84a4c13 into semver4j:main Apr 17, 2024
3 checks passed
@severn-everett severn-everett deleted the internal_static_only branch April 29, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Small task connected with refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert internal package to use only static functions instead of instances
2 participants