Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert handling #2959

Open
travi opened this issue Sep 15, 2023 · 0 comments
Open

revert handling #2959

travi opened this issue Sep 15, 2023 · 0 comments

Comments

@travi
Copy link
Member

travi commented Sep 15, 2023

tl;dr: add an integration test for the revert behavior when a change is committed and reverted in the scope of the same release

the recent changes with the conventional-changelog dependencies changed the order that the commits are processed. we have tests in the related plugins to cover the expected revert behavior, but this change resulted in a need to change the test data. that sent me on an investigation to confirm that the real commit data would actually match the new order of the test data and i failed to find a higher level test that covered the scope of reading the commits and handling the revert behavior.

i ended up doing some manual tests, as mentioned in #2934 (comment). i dont want getting this test added to further delay getting #2934 released, so capturing this for a follow up.

we should add an integration test in this project for this case since it would have a large enough scope to cover all of the pieces involved. in addition, i think there is an opportunity to extract some helper functions to reduce some duplication in the integration test file and make the tests easier to read and follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant