fix: address @octokit/rest deprecations (#249)

Author: gr2m

lib/get-client.js

@@ -1,5 +1,5 @@
 const {memoize, get} = require('lodash');
-const Octokit = require('@octokit/rest');
+const {Octokit} = require('@octokit/rest');
 const pRetry = require('p-retry');
 const Bottleneck = require('bottleneck');
 const urljoin = require('url-join');

lib/publish.js

@@ -67,7 +67,7 @@ module.exports = async (pluginConfig, context) => {
       const fileName = template(asset.name || basename(filePath))(context);
       const upload = {
         url: uploadUrl,
-        file: await readFile(resolve(cwd, filePath)),
+        data: await readFile(resolve(cwd, filePath)),
         name: fileName,
         headers: {
           'content-type': mime.getType(extname(fileName)) || 'text/plain',

lib/success.js

@@ -49,9 +49,8 @@ module.exports = async (pluginConfig, context) => {
     const prs = await pFilter(
       uniqBy(flatten(await Promise.all(searchQueries)), 'number'),
       async ({number}) =>
-        (await github.pullRequests.listCommits({owner, repo, pull_number: number})).data.find(({sha}) =>
-          shas.includes(sha)
-        ) || shas.includes((await github.pullRequests.get({owner, repo, pull_number: number})).data.merge_commit_sha)
+        (await github.pulls.listCommits({owner, repo, pull_number: number})).data.find(({sha}) => shas.includes(sha)) ||
+        shas.includes((await github.pulls.get({owner, repo, pull_number: number})).data.merge_commit_sha)
     );
 
     debug(

package.json

@@ -16,7 +16,7 @@
     "Gregor Martynus (https://twitter.com/gr2m)"
   ],
   "dependencies": {
-    "@octokit/rest": "^16.27.0",
+    "@octokit/rest": "^16.43.0",
     "@semantic-release/error": "^2.2.0",
     "aggregate-error": "^3.0.0",
     "bottleneck": "^2.18.1",

test/get-client.test.js

@@ -9,7 +9,7 @@ const {stub, spy} = require('sinon');
 const proxyquire = require('proxyquire');
 const Proxy = require('proxy');
 const serverDestroy = require('server-destroy');
-const Octokit = require('@octokit/rest');
+const {Octokit} = require('@octokit/rest');
 const rateLimit = require('./helpers/rate-limit');
 
 const getClient = proxyquire('../lib/get-client', {'./definitions/rate-limit': rateLimit});
@@ -94,7 +94,7 @@ test('Use the global throttler for all endpoints', async t => {
   const octokit = new Octokit();
   octokit.hook.wrap('request', () => Date.now());
   const github = proxyquire('../lib/get-client', {
-    '@octokit/rest': stub().returns(octokit),
+    '@octokit/rest': {Octokit: stub().returns(octokit)},
     './definitions/rate-limit': {RATE_LIMITS: {search: 1, core: 1}, GLOBAL_RATE_LIMIT: rate},
   })({githubToken: 'token'});
 
@@ -124,7 +124,7 @@ test('Use the same throttler for endpoints in the same rate limit group', async
   const octokit = new Octokit();
   octokit.hook.wrap('request', () => Date.now());
   const github = proxyquire('../lib/get-client', {
-    '@octokit/rest': stub().returns(octokit),
+    '@octokit/rest': {Octokit: stub().returns(octokit)},
     './definitions/rate-limit': {RATE_LIMITS: {search: searchRate, core: coreRate}, GLOBAL_RATE_LIMIT: 1},
   })({githubToken: 'token'});
 
@@ -155,7 +155,7 @@ test('Use different throttler for read and write endpoints', async t => {
   const octokit = new Octokit();
   octokit.hook.wrap('request', () => Date.now());
   const github = proxyquire('../lib/get-client', {
-    '@octokit/rest': stub().returns(octokit),
+    '@octokit/rest': {Octokit: stub().returns(octokit)},
     './definitions/rate-limit': {RATE_LIMITS: {core: {write: writeRate, read: readRate}}, GLOBAL_RATE_LIMIT: 1},
   })({githubToken: 'token'});
 
@@ -181,7 +181,7 @@ test('Use the same throttler when retrying', async t => {
   const octokit = new Octokit();
   octokit.hook.wrap('request', request);
   const github = proxyquire('../lib/get-client', {
-    '@octokit/rest': stub().returns(octokit),
+    '@octokit/rest': {Octokit: stub().returns(octokit)},
     './definitions/rate-limit': {
       RETRY_CONF: {retries: 3, factor: 1, minTimeout: 1},
       RATE_LIMITS: {core: coreRate},