Skip to content

Commit bd4322d

Browse files
committedDec 5, 2019
feat: require Node.js >=10.13
BREAKING CHANGE: Require Node.js >= 10.13
1 parent 7aaeb0f commit bd4322d

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed
 

‎.travis.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@ language: node_js
22

33
node_js:
44
- 12
5-
- 10
6-
- 8.16
5+
- 10.13
76

87
# Trigger a push build on release and greenkeeper branches + PRs build on every branches
98
# Avoid double build on PRs (See https://github.com/travis-ci/travis-ci/issues/1147)

‎lib/get-client.js

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
const {URL} = require('url');
21
const {memoize, get} = require('lodash');
32
const Octokit = require('@octokit/rest');
43
const pRetry = require('p-retry');

‎lib/parse-github-url.js

+2-4
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
1-
const {URL} = require('url');
2-
31
module.exports = repositoryUrl => {
4-
const [match, auth, host, path] = /^(?!.+:\/\/)(?:(.*)@)?(.*?):(.*?)$/.exec(repositoryUrl) || [];
2+
const [match, auth, host, path] = /^(?!.+:\/\/)(?:(?<auth>.*)@)?(?<host>.*?):(?<path>.*)$/.exec(repositoryUrl) || [];
53
try {
6-
const [, owner, repo] = /^\/([^/]+)?\/?(.+?)(?:\.git)?$/.exec(
4+
const [, owner, repo] = /^\/(?<owner>[^/]+)?\/?(?<repo>.+?)(?:\.git)?$/.exec(
75
new URL(match ? `ssh://${auth ? `${auth}@` : ''}${host}/${path}` : repositoryUrl).pathname
86
);
97
return {owner, repo};

‎package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
"xo": "^0.25.2"
4949
},
5050
"engines": {
51-
"node": ">=8.16"
51+
"node": ">=10.13"
5252
},
5353
"files": [
5454
"lib",

0 commit comments

Comments
 (0)
Please sign in to comment.