Download with redirect #2692
Merged
Download with redirect #2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Content-Disposition") Currently, it fails for HTTPGET method.
…redirect (without header "Content-Disposition") Fixed for HTTPGET method: now we detect URL of a last redirect, and extract filename from this URL.
* avoid using FilenameUtils.getExtension() because it throws "IllegalArgumentException: NTFS ADS separator (':') in file name is forbidden" - we don't need this check. Some of our tests do have filenames with forbidden characters.
* instead, extract file extension with a simple regex.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.