Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Animated Condition #2556

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Add Animated Condition #2556

merged 2 commits into from
Feb 6, 2024

Conversation

BorisOsipov
Copy link
Member

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Checklist

  • Checkstyle and unit tests are passed locally with my changes by running gradlew check chrome_headless firefox_headless command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@BorisOsipov BorisOsipov force-pushed the add_animation_check branch 2 times, most recently from 920ab53 to f9b58c8 Compare November 19, 2023 12:16
Copy link

sonarcloud bot commented Nov 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@BorisOsipov BorisOsipov changed the title Add Animated Condition. Forbid clickin on animated element. Add Animated Condition Feb 5, 2024
@BorisOsipov BorisOsipov marked this pull request as ready for review February 5, 2024 16:12
src/main/resources/animation.js Outdated Show resolved Hide resolved
@asolntsev asolntsev added this to the 7.1.0 milestone Feb 6, 2024
Copy link

sonarcloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@BorisOsipov BorisOsipov merged commit 1d3947a into main Feb 6, 2024
12 of 13 checks passed
@BorisOsipov BorisOsipov deleted the add_animation_check branch February 6, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants