Refactor collection conditions #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it's the preferred method. Will replace the previous method `test(List<WebElement>)`.
P.S. replaced useless unit-tests by analogous integration test
P.S. replaced useless unit-tests by analogous integration test
P.S. replaced useless unit-tests by analogous integration test
instead of old `fail(..List elements..)`
It will speed up the tests: we will not fetch actual attribute values when generating an error message
P.S. replaced useless unit-tests by analogous integration test
replaced useless unit-tests by analogous integration test
asolntsev
force-pushed
the
refactor-collection-conditions
branch
from
398dddd
to
343f472
Compare
asolntsev
force-pushed
the
refactor-collection-conditions
branch
from
77dc8c8
to
b8723b6
Compare
replaced useless unit-tests by analogous integration test
replaced useless unit-tests by analogous integration test
replaced useless unit-tests by analogous integration test
replaced useless unit-tests by analogous integration test
replaced useless unit-tests by analogous integration test
asolntsev
force-pushed
the
refactor-collection-conditions
branch
from
b8723b6
to
a5e931f
Compare
replaced useless unit-tests by analogous integration test
asolntsev
force-pushed
the
refactor-collection-conditions
branch
from
0d0c57a
to
0bef8ae
Compare
replaced useless unit-tests by analogous integration test
replaced useless unit-tests by analogous integration test
In most tests, we don't really need to wait 4 seconds. There is only a few tests where we do want to test the "waiting".
asolntsev
force-pushed
the
refactor-collection-conditions
branch
from
ec4bbcd
to
8cdd60a
Compare
replaced useless unit-tests by analogous integration test
replaced useless unit-tests by analogous integration test
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new (primary) method in
CollectionCondition:This method will be preferred over current method
because it will allow new features:
Also, in this PR I reviewed existing tests of collection conditions, and converted many (quite useless) unit-tests to integration tests. And added more detailed checks for their output.