Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2288 Wait until element becomes enabled before click #2290

Merged
merged 2 commits into from May 23, 2023
Merged

#2288 Wait until element becomes enabled before click #2290

merged 2 commits into from May 23, 2023

Conversation

Au6ojlut
Copy link
Contributor

Proposed changes

Fix for issue #2288

Checklist

  • Checkstyle and unit tests are passed locally with my changes by running gradlew check chrome_headless firefox_headless command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Au6ojlut Au6ojlut marked this pull request as draft May 20, 2023 13:58
@asolntsev asolntsev self-assigned this May 20, 2023
@Au6ojlut
selenide#2288 Fix error messages in tests
8f215cc 
Before the change the clicked element had to be `interactable`, but after the change it must be `clickable: interactable and enabled`
@sonarcloud
Copy link

sonarcloud bot commented May 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Au6ojlut Au6ojlut marked this pull request as ready for review May 20, 2023 16:00
@asolntsev asolntsev added this to the 6.15.0 milestone May 22, 2023
@asolntsev asolntsev linked an issue May 23, 2023 that may be closed by this pull request
Clicking on disabled elements (buttons) should fail the same way as clicking on covered ones #2288
Closed
@asolntsev asolntsev merged commit 743a3d1 into selenide:main May 23, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asolntsev asolntsev asolntsev approved these changes

Assignees

@asolntsev asolntsev

Labels
feature
Projects
None yet
Milestone
6.15.0
Development

Successfully merging this pull request may close these issues.

Clicking on disabled elements (buttons) should fail the same way as clicking on covered ones
2 participants
@Au6ojlut @asolntsev