This repository has been archived by the owner on Feb 13, 2024. It is now read-only.
Add an errorHandler property to constructor options #342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✔️ All existing tests pass
✔️ New functionality is unit-tested
Addresses #320 #326
What this adds
This PR adds an optional
errorHandler
property to the class constructor's options.If unspecified, the behaviour of the library does not change.
If specified, when an axios request fails,
errorHandler(axiosError)
will be called instead of re-throwing the axios error.Example usage:
Why
Since no way to handle the re-thrown axios error was exposed previously, this meant that if the axios request failed for any reason, the application using analytics-node would crash. A workaround was to use node's process
unhandledRejection
orunhandledException
handlers, but this is very un-ergonomic for library users.Work remaining
This functionality needs to be documented: https://segment.com/docs/connections/sources/catalog/libraries/server/node/