Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save code editor size preference as percentage #363

Merged
merged 11 commits into from
Sep 17, 2024
Merged

Conversation

felixhabib
Copy link
Contributor

@felixhabib felixhabib commented Sep 9, 2024

See changeset.

Setting the defaults to 40% as these look pretty good even at smaller screen sizes, but open to suggestions if this should be different.

@felixhabib felixhabib requested a review from a team as a code owner September 9, 2024 06:25
Copy link

changeset-bot bot commented Sep 9, 2024

🦋 Changeset detected

Latest commit: 6f61b4f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
playroom Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@felixhabib felixhabib changed the title Save code Editor size preference as percentage Save code editor size preference as percentage Sep 9, 2024
Co-authored-by: Michael Taranto <michaeltaranto@users.noreply.github.com>
felixhabib and others added 2 commits September 10, 2024 16:20
Co-authored-by: Michael Taranto <michaeltaranto@users.noreply.github.com>
@felixhabib felixhabib marked this pull request as draft September 12, 2024 03:11
Convert preference to percentage on load
@felixhabib felixhabib marked this pull request as ready for review September 12, 2024 05:22
@felixhabib felixhabib marked this pull request as draft September 12, 2024 23:07
@felixhabib felixhabib force-pushed the code-pane-height branch 2 times, most recently from cc2cb89 to e301da5 Compare September 13, 2024 07:25
@felixhabib felixhabib marked this pull request as ready for review September 15, 2024 23:50
Copy link
Contributor

@askoufis askoufis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Much nicer experience when resizing.

Copy link
Contributor

@michaeltaranto michaeltaranto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So good. Love where this landed, very tidy 👏

@felixhabib felixhabib merged commit d902e17 into master Sep 17, 2024
6 checks passed
@felixhabib felixhabib deleted the code-pane-height branch September 17, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants