fix: correctly identify infixed concats as potential SQL injections #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audunmo
commented
Jul 21, 2023
audunmo
commented
Jul 21, 2023
audunmo
commented
Jul 24, 2023
ccojocar
requested changes
Jul 25, 2023
|
Also please fix the lint warnings. You can run the golanci-lint locally. |
|
@ccojocar thanks for the review, will fix |
ccojocar
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't have an issue, popped up while I was investigating #885
In some cases, gosec fails to fully evaluate statements where string concatenations contain variable components. This leads to it missing potential SQL injection vulnerabilities that are "infixed", i.e.
"INSERT INTO foo VALUES (name) ('" + os.Args[0] + "')"