Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gochecknoinits; fix lint issues; use consts for some vars #1022

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

alexandear
Copy link
Contributor

This PR enables gochecknoinits linter. And fixes appeared issue by removing init() function from the cwe package.
Also, refactors InformationURI and DownloadURI initialization.

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4def3a4) 72.41% compared to head (35fa5ab) 72.38%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1022      +/-   ##
==========================================
- Coverage   72.41%   72.38%   -0.04%     
==========================================
  Files          50       50              
  Lines        3386     3382       -4     
==========================================
- Hits         2452     2448       -4     
  Misses        863      863              
  Partials       71       71              
Files Coverage Δ
cwe/data.go 83.33% <100.00%> (-6.67%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ccojocar ccojocar merged commit d864a91 into securego:master Oct 5, 2023
6 checks passed
@alexandear alexandear deleted the enable-gochecknoinits branch October 5, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants