Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyTorch Support #308

Open
deevashwer opened this issue Aug 16, 2023 · 7 comments
Open

PyTorch Support #308

deevashwer opened this issue Aug 16, 2023 · 7 comments

Comments

@deevashwer
Copy link

I see that SPU already has experimental support for PyTorch. Has it been tested on a transformer model yet (even for inference)?

@anakinxc
Copy link
Contributor

Hi @deevashwer

PyTorch support is still at it's very early stage, the demo is just showing it's potential...

Technically things like this might work fine with SPU.

@deevashwer
Copy link
Author

Thanks! Is PyTorch support a priority for the SecretFlow team? If yes, is it possible to give a rough estimate on the timeline for this?

@anakinxc
Copy link
Contributor

Thanks! Is PyTorch support a priority for the SecretFlow team? If yes, is it possible to give a rough estimate on the timeline for this?

Better PyTorch support is definitely something we would like to see, but it's not a priority at this point.

Feedbacks and inside thoughts that can help us make a better judgement are welcome :D

@deevashwer
Copy link
Author

You probably already know this, but I would vouch for PyTorch simply because it is by far the most widely adopted framework and it unlocks the entire huggingface library. If you look here, everything is supported in PyTorch, and TF and JAX support is relatively sparse. All the state-of-the-art models (not just in NLP) are also typically released in PyTorch. So you stand to unlock all the models, if a robust support for PyTorch is added to SecretFlow.

@anakinxc
Copy link
Contributor

You probably already know this, but I would vouch for PyTorch simply because it is by far the most widely adopted framework and it unlocks the entire huggingface library. If you look here, everything is supported in PyTorch, and TF and JAX support is relatively sparse. All the state-of-the-art models (not just in NLP) are also typically released in PyTorch. So you stand to unlock all the models, if a robust support for PyTorch is added to SecretFlow.

Thanks for the inputs, I'll bring this up to our team.

@github-actions
Copy link

Stale issue message. Please comment to remove stale tag. Otherwise this issue will be closed soon.

@anakinxc
Copy link
Contributor

Hi @deevashwer

We just made some improvements on Torch support, check here. Feel free to give it a shot.

Be aware, due to an issue in huggingface/transformers, we do not support models from huggingface at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants