-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger warning when code coverage analysis is performed and no cache directory is configured #6150
Comments
So you are meaning that cache is mandatory for code coverage analysis? Thank you |
We got this issue in our pipelines suddenly 2 days back. Had to update the cache directory to get this working and it's wired.
following is the warning. But this was not there 2,3 days back - strange
|
I have had a couple CI pipelines fail as a result of this change. Perhaps this warning is a bit overzealous? My <?xml version="1.0"?>
<phpunit failOnWarning="false" Configuring Why do I need to change my configuration now when it used to work fine before? What is the proper resolution for this? |
@sebastianbergmann I see now that the trigger is a phpunit 12.1 milestone. But I am currently using version 11. Maybe you can raise the trigger warning only if the version is 12 or (12.1) or above? |
Those two changes are unrelated. I have reverted the warning in PHPUnit 11.5 and PHPUnit 12.0. |
+1 for reverting the warning as pointed out in 6565fa7#r154096373 landed/reverted in 82c0b24 Please never require explicit cache directory. Implicit system cache directory should be used instead when accessible. The reason is we want to keep our configs minimal as possible. @sebastianbergmann would you mind to tag a new releases with the revert? |
No description provided.
The text was updated successfully, but these errors were encountered: