Precision loss in aggregated test suite execution time(s) reported by JUnit XML logger

[niconoe-]

Q	A
PHPUnit version	>= 12.0.0
PHP version	8.3.* or 8.4.*
Installation Method	Composer

Summary

Since PHPUnit 12, the execution time of testsuites has been truncated as integers (seconds), which makes losing the precision. For extra processing like summing or averaging using the JUnit report, this causes wrong calculation or worse: division by zero on averages calculations.

Current behavior

In the JUnit report in XML since PHPUnit 12, on tags, the time attribute is cast as an integer (even if displayed as a float).

How to reproduce

Just run a test suite and look at the JUnit report.

Expected behavior

The expected behavior is to keep the highest possible precision on filling the time attribute, and not losing the milliseconds.

Additional information

I think the issue is coming from the additional cast into an integer of the $time variable here:

phpunit/src/Logging/JUnit/JunitXmlLogger.php

Line 288 in 6301fe5

$this->testSuiteTimes[$this->testSuiteLevel] += (int) $time;

Comparing to the latest v11, where there is no cast:

phpunit/src/Logging/JUnit/JunitXmlLogger.php

Line 288 in e1cb706

$this->testSuiteTimes[$this->testSuiteLevel] += $time;

I don't know if there is any other implications about removing the cast (PHPStan / Psalm / unit tests / infections…) so I'm not sure I can provide a PR and take care about it. If that's really as simple as removing the cast and no implication so far, I can do it.

[niconoe-]

That was fast as lightning! TYVM!