TestSuite\Loaded event has incomplete Event\TestSuite\TestSuite value object

[sebastianbergmann]

This can be reproduced using this var_dump() call:

diff --git a/src/Event/Emitter/DispatchingEmitter.php b/src/Event/Emitter/DispatchingEmitter.php
index 1b89c1e5a..d2f19fe62 100644
--- a/src/Event/Emitter/DispatchingEmitter.php
+++ b/src/Event/Emitter/DispatchingEmitter.php
@@ -136,6 +136,8 @@ public function testRunnerBootstrappedExtension(string $className, array $parame
      */
     public function testSuiteLoaded(TestSuite $testSuite): void
     {
+        var_dump($testSuite);
+
         $this->dispatcher->dispatch(
             new TestSuiteLoaded(
                 $this->telemetryInfo(),

phpunit.xml

<?xml version="1.0" encoding="UTF-8"?>
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.1/phpunit.xsd">
    <testsuites>
        <testsuite name="default">
            <directory>tests</directory>
        </testsuite>
    </testsuites>
</phpunit>

tests/Test.php

<?php declare(strict_types=1);
use PHPUnit\Framework\TestCase;

final class Test extends TestCase
{
    public function testOne(): void
    {
        $this->assertTrue(true);
    }
}

Invoking the test runner without an argument

This does not work as expected (the tests array is empty):

phpunit --no-output
object(PHPUnit\Event\TestSuite\TestSuiteWithName)#90 (3) {
  ["name":"PHPUnit\Event\TestSuite\TestSuite":private]=>
  string(0) ""
  ["count":"PHPUnit\Event\TestSuite\TestSuite":private]=>
  int(1)
  ["tests":"PHPUnit\Event\TestSuite\TestSuite":private]=>
  object(PHPUnit\Event\Code\TestCollection)#92 (1) {
    ["tests":"PHPUnit\Event\Code\TestCollection":private]=>
    array(0) {
    }
  }
}

Invoking the test runner with the path to a test source file as an argument

This works as expected:

$ phpunit --no-output tests/Test.php
object(PHPUnit\Event\TestSuite\TestSuiteForTestClass)#324 (6) {
  ["name":"PHPUnit\Event\TestSuite\TestSuite":private]=>
  string(4) "Test"
  ["count":"PHPUnit\Event\TestSuite\TestSuite":private]=>
  int(1)
  ["tests":"PHPUnit\Event\TestSuite\TestSuite":private]=>
  object(PHPUnit\Event\Code\TestCollection)#325 (1) {
    ["tests":"PHPUnit\Event\Code\TestCollection":private]=>
    array(1) {
      [0]=>
      object(PHPUnit\Event\Code\TestMethod)#91 (7) {
        ["file":"PHPUnit\Event\Code\Test":private]=>
        string(27) "/home/sb/bug/tests/Test.php"
        ["className":"PHPUnit\Event\Code\TestMethod":private]=>
        string(4) "Test"
        ["methodName":"PHPUnit\Event\Code\TestMethod":private]=>
        string(7) "testOne"
        ["line":"PHPUnit\Event\Code\TestMethod":private]=>
        int(6)
        ["testDox":"PHPUnit\Event\Code\TestMethod":private]=>
        object(PHPUnit\Event\Code\TestDox)#92 (3) {
          ["prettifiedClassName":"PHPUnit\Event\Code\TestDox":private]=>
          string(13) "Unnamed Tests"
          ["prettifiedMethodName":"PHPUnit\Event\Code\TestDox":private]=>
          string(3) "One"
          ["prettifiedAndColorizedMethodName":"PHPUnit\Event\Code\TestDox":private]=>
          string(3) "One"
        }
        ["metadata":"PHPUnit\Event\Code\TestMethod":private]=>
        object(PHPUnit\Metadata\MetadataCollection)#328 (1) {
          ["metadata":"PHPUnit\Metadata\MetadataCollection":private]=>
          array(0) {
          }
        }
        ["testData":"PHPUnit\Event\Code\TestMethod":private]=>
        object(PHPUnit\Event\TestData\TestDataCollection)#93 (2) {
          ["data":"PHPUnit\Event\TestData\TestDataCollection":private]=>
          array(0) {
          }
          ["fromDataProvider":"PHPUnit\Event\TestData\TestDataCollection":private]=>
          NULL
        }
      }
    }
  }
  ["className":"PHPUnit\Event\TestSuite\TestSuiteForTestClass":private]=>
  string(4) "Test"
  ["file":"PHPUnit\Event\TestSuite\TestSuiteForTestClass":private]=>
  string(27) "/home/sb/bug/tests/Test.php"
  ["line":"PHPUnit\Event\TestSuite\TestSuiteForTestClass":private]=>
  int(4)
}

[sebastianbergmann]

CC @Ocramius @theseer

[sebastianbergmann]

This is likely caused by missing recursive iteration in PHPUnit\Event\TestSuite\TestSuiteBuilder::from() which builds an PHPUnit\Event\TestSuite\TestSuite value object from a PHPUnit\Framework\TestSuite object.

[Ocramius]

Whoa, really elegant solution! 💪

Mine was a blob of ugly recursive code...

[sebastianbergmann]

Whoa, really elegant solution! 💪

Looks like I need to find a different solution. But not today :)

[sebastianbergmann]

The tests added in 4984c50 will prevent the regression reported in #5393 when I have another go at this.