Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow binding interface #2163

Merged
merged 1 commit into from Mar 11, 2024
Merged

Allow binding interface #2163

merged 1 commit into from Mar 11, 2024

Conversation

yujincheng08
Copy link
Contributor

@yujincheng08 yujincheng08 commented Mar 9, 2024 •
edited

Fix #1336

@seanmonstar
Copy link
Owner

Looks good! Any reason to restrict it to only Linux?

@yujincheng08
Copy link
Contributor Author

@seanmonstar Hi, it comes from here: https://github.com/hyperium/hyper-util/blob/a24c162f89879271801af196c861fb1a22c1dac7/src/client/legacy/connect/http.rs#L306

@seanmonstar seanmonstar merged commit 037111f into seanmonstar:master Mar 11, 2024
32 checks passed
@yujincheng08 yujincheng08 deleted the bind branch March 11, 2024 12:43
seanmonstar pushed a commit that referenced this pull request Mar 19, 2024
@yujincheng08 @seanmonstar
feat: Allow binding interface (#2163)
0ab9ef8
seanmonstar pushed a commit that referenced this pull request Mar 19, 2024
@yujincheng08 @seanmonstar
feat: Allow binding interface (#2163)
d3311fb
seanmonstar pushed a commit that referenced this pull request Mar 19, 2024
@yujincheng08 @seanmonstar
feat: Allow binding interface (#2163)
cb02e62
seanmonstar pushed a commit that referenced this pull request Mar 20, 2024
@yujincheng08 @seanmonstar
feat: Allow binding interface (#2163)
e2654c1
seanmonstar pushed a commit that referenced this pull request Mar 20, 2024
@yujincheng08 @seanmonstar
feat: Allow binding interface (#2163)
50bbfa2
seanmonstar pushed a commit that referenced this pull request Mar 20, 2024
@yujincheng08 @seanmonstar
feat: Allow binding interface (#2163)
18f2bb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

local_address doesn't connect unless interface is highest priority
2 participants
@yujincheng08 @seanmonstar