Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to hyper 1.0 #2039

Closed
5 tasks done
seanmonstar opened this issue Nov 15, 2023 · 14 comments · Fixed by #2059
Closed
5 tasks done

Upgrade to hyper 1.0 #2039

seanmonstar opened this issue Nov 15, 2023 · 14 comments · Fixed by #2059
Labels
B-breaking-change Blocked: breaking change.
Milestone
0.12

Comments

@seanmonstar
Copy link
Owner

seanmonstar commented Nov 15, 2023 •
edited

A tracking issue for upgrading reqwest to use hyper 1.0. It'll be a breaking change, and we should probably include some other breaking fixes that have piled up. But those can be tracked else where. This is just the items needed to update the hyper dependency.
@seanmonstar seanmonstar added B-upstream Blocked: upstream. Depends on a dependency to make a change first. B-breaking-change Blocked: breaking change. labels Nov 15, 2023
@seanmonstar seanmonstar pinned this issue Nov 15, 2023
@seanmonstar seanmonstar added this to the 0.12 milestone Nov 15, 2023
@ttys3 ttys3 mentioned this issue Nov 16, 2023
Closed
3 tasks
@photino photino mentioned this issue Nov 16, 2023
Closed
This was referenced Nov 16, 2023
Closed
Closed
Closed
@b4s36t4 b4s36t4 mentioned this issue Nov 17, 2023
Open
@dotansimha dotansimha mentioned this issue Nov 19, 2023
Closed
1 task
@Xuanwo Xuanwo mentioned this issue Nov 21, 2023
Closed
2 tasks
@casey casey mentioned this issue Nov 22, 2023
Open
@jonhoo jonhoo mentioned this issue Nov 25, 2023
Closed
@chrislearn chrislearn mentioned this issue Nov 27, 2023
Closed
@0xdeafbeef 0xdeafbeef mentioned this issue Nov 27, 2023
Open
@DaniPopes DaniPopes mentioned this issue Nov 30, 2023
Merged
@ngutech21 ngutech21 mentioned this issue Dec 3, 2023
Closed
@jacobtread jacobtread mentioned this issue Dec 5, 2023
Closed
2 tasks
@dignifiedquire dignifiedquire mentioned this issue Dec 5, 2023
Merged
3 tasks
@flub flub mentioned this issue Dec 5, 2023
Open
@seanmonstar seanmonstar mentioned this issue Dec 5, 2023
Closed
@Threated Threated mentioned this issue Dec 7, 2023
Open
@seanmonstar seanmonstar mentioned this issue Dec 7, 2023
Merged
@yanorei32 yanorei32 mentioned this issue Dec 8, 2023
Open
3 tasks
@minghuaw minghuaw mentioned this issue Dec 8, 2023
Open
This was referenced Dec 13, 2023
Closed
Closed
@seanmonstar seanmonstar mentioned this issue Dec 14, 2023
Closed
@NobodyXu NobodyXu mentioned this issue Dec 26, 2023
Closed
@mbfm mbfm mentioned this issue Jan 16, 2024
Open
@KallDrexx KallDrexx mentioned this issue Jan 18, 2024
Open
@LNSD LNSD mentioned this issue Jan 19, 2024
Closed
1 task
@rakshith-ravi
Copy link
Contributor

hyper-rustls 0.26 now seems to support hyper 1.0.

@jsantell jsantell mentioned this issue Jan 22, 2024
Open
6 tasks
ctron added a commit to ctron/trunk that referenced this issue Jan 26, 2024
@ctron
refactor: upgrade to http 1.x
36ae00c 
Currently blocked by seanmonstar/reqwest#2039
@ctron ctron mentioned this issue Jan 26, 2024
Merged
@damooo damooo mentioned this issue Feb 4, 2024
Open
mstange added a commit to mstange/samply that referenced this issue Feb 13, 2024
@mstange
Update hyper to 1.1.0.
df3494d 
We now build hyper twice because reqwest still depends on hyper 0.14.
This will be solved once reqwest is on hyper 1.
seanmonstar/reqwest#2039
@stephank stephank mentioned this issue Feb 14, 2024
Closed
@amrbashir amrbashir mentioned this issue Feb 15, 2024
Merged
1 task
@mladedav mladedav mentioned this issue Feb 16, 2024
Closed
@seanmonstar
Copy link
Owner Author

Made a lot of progress today, most tests are passing. Seems the unstable h3 feature is blocked, since Quinn currently depends on rustls 0.21 (quinn-rs/quinn#1715), but hyper-rustls depends on rustls 0.22.

@seanmonstar seanmonstar removed the B-upstream Blocked: upstream. Depends on a dependency to make a change first. label Feb 19, 2024
This was referenced Feb 19, 2024
Closed
Closed
@ologbonowiwi
Copy link

@seanmonstar merging #2059 is expected to be a breaking change? Asking because I'm working on a service that depends on reqwest and we plan to update to hyper v1.

It's recommended to wait for this to be closed, or the public APIs will not be changed?

@NobodyXu
Copy link
Contributor

I skimmed through the PR and the only "breaking" change I found is the temporary removal of http3 feature, which is gated behind reqwest unstable cfg so it's probably ok.

@ramosbugs ramosbugs mentioned this issue Mar 4, 2024
Closed
@DaniPopes DaniPopes mentioned this issue Mar 6, 2024
Merged
9 tasks
@clux clux mentioned this issue Mar 7, 2024
Closed
13 tasks
@scottlamb
Copy link

First of all, yay, it's done and merged!

I skimmed through the PR and the only "breaking" change I found is the temporary removal of http3 feature, which is gated behind reqwest unstable cfg so it's probably ok.

I'm skeptical. I thought many public types such as reqwest::headers::HeaderMap were direct re-exports from http. They're now compatible with http 1.0 types rather than http 0.2 types. Isn't that a breaking change already? I think this needs to be released as reqwest 0.12.0 rather than 0.11.whatever?

@seanmonstar
Copy link
Owner Author

Correct, it is a breaking change. The exposed http types and integration are going from 0.2 to 1.0.

@seanmonstar seanmonstar unpinned this issue Mar 11, 2024
@mladedav
Copy link

Can I ask for a clarification about this? I see it's merged but not released yet but some versions with the old http version were released.

Is the release blocked on something else (docs or something else?) or does this just wait for the release itself?

@zecakeh
Copy link

zecakeh commented Mar 21, 2024

Reqwest 0.12 was released yesterday with this.

ctron added a commit to ctron/trunk that referenced this issue Mar 21, 2024
@ctron
refactor: upgrade to http 1.x
c22bb48 
Currently blocked by seanmonstar/reqwest#2039
@richardstrnad richardstrnad mentioned this issue Apr 5, 2024
Merged
@yanorei32 yanorei32 mentioned this issue Apr 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-breaking-change Blocked: breaking change.
Projects
None yet
Milestone
0.12
Development

Successfully merging a pull request may close this issue.

hyper v1 upgrade seanmonstar/reqwest