chore: hide internal features #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyurik
force-pushed
the
feature-cleanup
branch
from
1ca5980
to
93b75e5
Compare
nyurik
force-pushed
the
feature-cleanup
branch
from
25f25c0
to
92a93fc
Compare
|
Thanks for this PR! I'd been saving it for the breaking release that included the upgrade to hyper v1, which is now merged and 0.12 being prepared. Would you mind resolving the conflicts, and we can get this in? |
* In `Cargo.toml`, hide all optional dependencies as features Currently, reqwest publishes all optional dependencies as features - which is usually not what is intended. Instead, the features should be explicitly declared, whereas optional features are enabled with the new `dep:*` syntax. Note that I also had to fix a few conditional compilations which used optional crates rather than features as conditionals. Also, note the use of the `...?/...` syntax instead of `.../...` -- as this both enabled an optional crate AND adds a feature to it. Now, it uses the `"dep:...", "...?/..."` syntax to prevent exposing crate name.
|
thx for the ping, rebased, and reworked some feature conditionals |
seanmonstar
pushed a commit
that referenced
this pull request
Mar 19, 2024
In `Cargo.toml`, hide all optional dependencies as features Currently, reqwest publishes all optional dependencies as features - which is usually not what is intended. Instead, the features should be explicitly declared, whereas optional features are enabled with the new `dep:*` syntax. Note that I also had to fix a few conditional compilations which used optional crates rather than features as conditionals. Also, note the use of the `...?/...` syntax instead of `.../...` -- as this both enabled an optional crate AND adds a feature to it. Now, it uses the `"dep:...", "...?/..."` syntax to prevent exposing crate name. Technically, this is *breaking change*, since people may have enabled some of these features accidentally. That's why we're including it in 0.12.
seanmonstar
pushed a commit
that referenced
this pull request
Mar 19, 2024
In `Cargo.toml`, hide all optional dependencies as features Currently, reqwest publishes all optional dependencies as features - which is usually not what is intended. Instead, the features should be explicitly declared, whereas optional features are enabled with the new `dep:*` syntax. Note that I also had to fix a few conditional compilations which used optional crates rather than features as conditionals. Also, note the use of the `...?/...` syntax instead of `.../...` -- as this both enabled an optional crate AND adds a feature to it. Now, it uses the `"dep:...", "...?/..."` syntax to prevent exposing crate name. Technically, this is *breaking change*, since people may have enabled some of these features accidentally. That's why we're including it in 0.12.
seanmonstar
pushed a commit
that referenced
this pull request
Mar 19, 2024
In `Cargo.toml`, hide all optional dependencies as features Currently, reqwest publishes all optional dependencies as features - which is usually not what is intended. Instead, the features should be explicitly declared, whereas optional features are enabled with the new `dep:*` syntax. Note that I also had to fix a few conditional compilations which used optional crates rather than features as conditionals. Also, note the use of the `...?/...` syntax instead of `.../...` -- as this both enabled an optional crate AND adds a feature to it. Now, it uses the `"dep:...", "...?/..."` syntax to prevent exposing crate name. Technically, this is *breaking change*, since people may have enabled some of these features accidentally. That's why we're including it in 0.12.
seanmonstar
pushed a commit
that referenced
this pull request
Mar 20, 2024
In `Cargo.toml`, hide all optional dependencies as features Currently, reqwest publishes all optional dependencies as features - which is usually not what is intended. Instead, the features should be explicitly declared, whereas optional features are enabled with the new `dep:*` syntax. Note that I also had to fix a few conditional compilations which used optional crates rather than features as conditionals. Also, note the use of the `...?/...` syntax instead of `.../...` -- as this both enabled an optional crate AND adds a feature to it. Now, it uses the `"dep:...", "...?/..."` syntax to prevent exposing crate name. Technically, this is *breaking change*, since people may have enabled some of these features accidentally. That's why we're including it in 0.12.
seanmonstar
pushed a commit
that referenced
this pull request
Mar 20, 2024
In `Cargo.toml`, hide all optional dependencies as features Currently, reqwest publishes all optional dependencies as features - which is usually not what is intended. Instead, the features should be explicitly declared, whereas optional features are enabled with the new `dep:*` syntax. Note that I also had to fix a few conditional compilations which used optional crates rather than features as conditionals. Also, note the use of the `...?/...` syntax instead of `.../...` -- as this both enabled an optional crate AND adds a feature to it. Now, it uses the `"dep:...", "...?/..."` syntax to prevent exposing crate name. Technically, this is *breaking change*, since people may have enabled some of these features accidentally. That's why we're including it in 0.12.
seanmonstar
pushed a commit
that referenced
this pull request
Mar 20, 2024
In `Cargo.toml`, hide all optional dependencies as features Currently, reqwest publishes all optional dependencies as features - which is usually not what is intended. Instead, the features should be explicitly declared, whereas optional features are enabled with the new `dep:*` syntax. Note that I also had to fix a few conditional compilations which used optional crates rather than features as conditionals. Also, note the use of the `...?/...` syntax instead of `.../...` -- as this both enabled an optional crate AND adds a feature to it. Now, it uses the `"dep:...", "...?/..."` syntax to prevent exposing crate name. Technically, this is *breaking change*, since people may have enabled some of these features accidentally. That's why we're including it in 0.12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves feature cleanup changes from #2023
In
Cargo.toml, hide all optional dependencies as featuresCurrently, reqwest publishes all optional dependencies as features - which is usually not what is intended. Instead, the features should be explicitly declared, whereas optional features are enabled with the new
dep:*syntax.Note that I also had to fix a few conditional compilations which used optional crates rather than features as conditionals.
Also, note the use of the
...?/...syntax instead of.../...-- as this both enabled an optional crate AND adds a feature to it. Now, it uses the"dep:...", "...?/..."syntax to prevent exposing crate name.