Add Experimental HTTP/3 Support #1599

kckeiks · 2022-08-06T00:17:23Z

Add small pool of HTTP/3 connections.
Using (Rustls) TLS config for setting up connection.
Use the SendRequest to start sending a request.
Reuse DNS resolvers.

It would be great to get some feedback. Thanks in advance.

kckeiks · 2022-08-06T00:18:33Z

Reuse DNS resolvers.

Resolution is done internally in hyper so there is no way to reuse the resolvers without re-implementing most of what is already in hyper. Thoughts?

Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>

seanmonstar

This looks amazing so far 🤩

CI wants a rustfmt run.

Cargo.toml

src/async_impl/client.rs

Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>

seanmonstar

Looking real good!

src/async_impl/client.rs

src/async_impl/h3_client/mod.rs

Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>

seanmonstar · 2022-08-19T18:13:13Z

This is so so exciting. I've noticed you kept pushing changes, so I wasn't sure when you felt it was "ready". Or maybe you felt it always was and just kept tweaking things to be a little better while waiting for me, in which case sorry!

kckeiks · 2022-08-20T00:49:30Z

This is so so exciting. I've noticed you kept pushing changes, so I wasn't sure when you felt it was "ready". Or maybe you felt it always was and just kept tweaking things to be a little better while waiting for me, in which case sorry!

No problem! I did run some tests and found things that needed to be improved but now I think it's ready for another round of review. 😊

seanmonstar · 2022-08-25T00:28:11Z

Ok, this is phenomenal! Now I'm left wondering what the best way to expose an "experimental" features is...

Ideally it'd just require RUSTFLAGS=--cfg reqwest_unstable_h3 and we write cfg(reqwest_unstable_h3) internally.
But we can't publish a version to crates.io that has a git dependency on h3.
- Is there a way around this?
  - Can we abuse a build script to check for the flag and then edit the Cargo.toml? I know, sounds horrible. 🤷
    - Probably won' work, though...
So, do we just publish 0.0.0-breaking-galore.1 versions of h3 that reqwest can depend on?
Any other suggestions? 🙈

tshepang · 2022-08-25T02:02:10Z

Ideally it'd just require RUSTFLAGS=--cfg reqwest_unstable_h3 and we write cfg(reqwest_unstable_h3) internally.

Instead of leaving it behind feature flag, I'd say do a beta version and call for testing, and if an issue is found after a final is release that requires a breaking API, do a breaking release. You can just mention that it's experimental in docs to be clear it's fresh code.

tshepang · 2022-08-25T02:04:08Z

* But we can't publish a version to crates.io that has a git dependency on `h3`.
  
  * Is there a way around this?
    
    * Can we abuse a build script to check for the flag and then edit the `Cargo.toml`? I know, sounds horrible. shrug
      
      * Probably won' work, though...

* So, do we just publish `0.0.0-breaking-galore.1` versions of `h3` that `reqwest` can depend on?

The h3 people can be encouraged to publish an alpha version perhaps.

kckeiks · 2022-08-25T15:23:18Z

So, do we just publish 0.0.0-breaking-galore.1 versions of h3 that reqwest can depend on?

Yes, I think this would be better. Please let me know if I can help with that over in h3.

jirutka · 2022-10-10T19:22:04Z

Using (Rustls) TLS config for setting up connection.

Can you please implement it also for native-tls?

seanmonstar · 2022-10-10T21:04:19Z

Native-tls uses openssl on Linux, and they don't have the needed methods to start a QUIC connection.

seanmonstar · 2023-03-09T21:33:35Z

Alright, sorry for it taking so long. We've just now published h3 and h3-quinn at v0.0.1, specifically to unblock this PR. (We expect using it here will point out some annoyances quickly, and a quinn upgrade too, so it's not meant for a wider audience).

Would you want to upgrade this PR to use that? If not, I can do it likely next week.

kckeiks · 2023-03-10T00:44:25Z

Alright, sorry for it taking so long. We've just now published h3 and h3-quinn at v0.0.1, specifically to unblock this PR. (We expect using it here will point out some annoyances quickly, and a quinn upgrade too, so it's not meant for a wider audience).

Would you want to upgrade this PR to use that? If not, I can do it likely next week.

Sure! I can work on it this coming week.

kckeiks · 2023-03-16T00:04:05Z

I ran some tests. Seems fine. Ready for review.

seanmonstar

❤️ 🎉 🚀

araujo-luis · 2023-04-28T08:00:10Z

Would it make sense to implement an "HTTP2 fallback" logic in case the server does not support HTTP3?

seanmonstar · 2023-04-28T12:06:59Z

Yes, that'd be great! I've opened #1810 to track.

araujo-luis · 2023-04-28T12:54:05Z

Yes, that'd be great! I've opened #1810 to track.

Great! Will try to solve it!

kckeiks added 9 commits August 5, 2022 20:20

Add and hook up simplistic HTTP/3 Client

9896862

Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>

Pass Rustls config from Builder to H3 client constructor

bcf2ddd

Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>

Add Pool code from Hyper

797edbf

Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>

Add connection pool to HTTP/3 Client

5dd0e87

Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>

Construct http::Body from chunks when creating response

107372c

Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>

Add feature flags to example

808c0cc

Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>

Clean up code

d62d538

Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>

Add HTTP/3-client builder

57c6ab8

Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>

Use feature flag when creating Request for hyper and h3 clients

4a5f526

Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>

kckeiks force-pushed the add-http3-support branch from 415c81b to 4a5f526 Compare August 6, 2022 00:20

seanmonstar requested changes Aug 6, 2022

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

src/async_impl/client.rs Outdated Show resolved Hide resolved

Make HTTP/3 dependencies optional

eb66d19

Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>

kckeiks force-pushed the add-http3-support branch from dd06380 to de2ce98 Compare August 6, 2022 15:59

Add cfg to HTTP version enum

1b68cfc

Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>

kckeiks force-pushed the add-http3-support branch from de2ce98 to 1b68cfc Compare August 6, 2022 16:14

seanmonstar self-requested a review August 6, 2022 17:28

Send payload data in requests

8e3819e

Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>

seanmonstar requested changes Aug 8, 2022

View reviewed changes

src/async_impl/client.rs Outdated Show resolved Hide resolved

src/async_impl/client.rs Outdated Show resolved Hide resolved

src/async_impl/h3_client/mod.rs Outdated Show resolved Hide resolved

src/async_impl/h3_client/mod.rs Outdated Show resolved Hide resolved

Change visivility of HTTP/3-client builder

4c04036

Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>

joepio mentioned this pull request Aug 11, 2022

Support for QUIC/HTTP3 protocol actix/actix-web#309

Open

kckeiks added 6 commits August 12, 2022 18:04

Use the same type of request when resending it

d79fac4

Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>

Add HTTP/3 connector that reuses DNS resolvers

040384d

Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>

Add Resolver enum to hold different kinds of resolvers

9286bbb

Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>

Add trust-dns resolvers for HTTP/3

1fc2fb1

Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>

Move connector to its own module

08e46af

Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>

Add setter for enabling early data in TLS 1.3

7931f0c

Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>

kckeiks force-pushed the add-http3-support branch 3 times, most recently from f069009 to b2b3e80 Compare August 13, 2022 01:57

kckeiks force-pushed the add-http3-support branch from 96687b4 to a2019f0 Compare August 16, 2022 16:22

Prevent multiple QUIC connections to the same host

fe36257

Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>

kckeiks force-pushed the add-http3-support branch from a2019f0 to fe36257 Compare August 16, 2022 16:23

passcod mentioned this pull request Sep 7, 2022

Publishing to crates.io hyperium/h3#125

Closed

kckeiks mentioned this pull request Jan 19, 2023

feat: rpc server supports QUIC connections fleek-network/ursa#304

Open

kckeiks added 7 commits March 15, 2023 18:09

Merge branch 'master' into add-http3-support

33f0b33

Update dns resolver

f6ea3b8

Use new DynResolver

90fa6e1

Reuse dyn Resolver in client

8efb857

Remove unused import

b9e6ea0

Run fmt

6f5af0e

Update deps

e233841

seanmonstar approved these changes Mar 16, 2023

View reviewed changes

seanmonstar merged commit 57a8a01 into seanmonstar:master Mar 16, 2023
30 checks passed

seanmonstar mentioned this pull request Apr 28, 2023

Add Experimental HTTP/3 Support #1558

Closed

makorne mentioned this pull request Jul 19, 2023

gRPC HTTP/3 support in Tonic hyperium/tonic#339

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Experimental HTTP/3 Support #1599

Add Experimental HTTP/3 Support #1599

kckeiks commented Aug 6, 2022 •

edited

kckeiks commented Aug 6, 2022 •

edited

seanmonstar left a comment

seanmonstar left a comment

seanmonstar commented Aug 19, 2022

kckeiks commented Aug 20, 2022

seanmonstar commented Aug 25, 2022

tshepang commented Aug 25, 2022 •

edited

tshepang commented Aug 25, 2022

kckeiks commented Aug 25, 2022

jirutka commented Oct 10, 2022

seanmonstar commented Oct 10, 2022

seanmonstar commented Mar 9, 2023

kckeiks commented Mar 10, 2023

kckeiks commented Mar 16, 2023

seanmonstar left a comment

araujo-luis commented Apr 28, 2023 •

edited

seanmonstar commented Apr 28, 2023

araujo-luis commented Apr 28, 2023

Add Experimental HTTP/3 Support #1599

Add Experimental HTTP/3 Support #1599

Conversation

kckeiks commented Aug 6, 2022 • edited

kckeiks commented Aug 6, 2022 • edited

seanmonstar left a comment

Choose a reason for hiding this comment

seanmonstar left a comment

Choose a reason for hiding this comment

seanmonstar commented Aug 19, 2022

kckeiks commented Aug 20, 2022

seanmonstar commented Aug 25, 2022

tshepang commented Aug 25, 2022 • edited

tshepang commented Aug 25, 2022

kckeiks commented Aug 25, 2022

jirutka commented Oct 10, 2022

seanmonstar commented Oct 10, 2022

seanmonstar commented Mar 9, 2023

kckeiks commented Mar 10, 2023

kckeiks commented Mar 16, 2023

seanmonstar left a comment

Choose a reason for hiding this comment

araujo-luis commented Apr 28, 2023 • edited

seanmonstar commented Apr 28, 2023

araujo-luis commented Apr 28, 2023

kckeiks commented Aug 6, 2022 •

edited

kckeiks commented Aug 6, 2022 •

edited

tshepang commented Aug 25, 2022 •

edited

araujo-luis commented Apr 28, 2023 •

edited