Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Add Ruby 3.4, drop Ruby 3.0 (EOL) #194

Merged
merged 1 commit into from
Mar 3, 2025
Merged

CI: Add Ruby 3.4, drop Ruby 3.0 (EOL) #194

merged 1 commit into from
Mar 3, 2025
+1 −1

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Feb 28, 2025 •
edited
Loading

This PR only updates the CI matrix to the latest generally available Ruby versions.

@olleolleolle
CI: Add Ruby 3.4, drop Ruby 3.0 (EOL)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
07a945c
@olleolleolle
Copy link
Contributor Author

Hm, perhaps we have a linting issue.

Errors on modified lines:
/home/runner/work/slim-lint/slim-lint/lib/slim_lint/atom.rb:91:7: C: [Correctable] Style/RedundantCondition: Use double pipes `||` instead.

✗ One or more pre-commit hooks failed

sds added a commit that referenced this pull request Mar 3, 2025
@sds
Fix RuboCop check

Verified

This commit was signed with the committer’s verified signature.
sds Shane da Silva
GPG key ID: E1DCA555AB2A8D37
Verified
Learn about vigilant mode
Loading
Loading status checks…
de04c4b 
This fails with RuboCop running on Ruby 3.4 (see #194).
@sds sds mentioned this pull request Mar 3, 2025
Merged
sds added a commit that referenced this pull request Mar 3, 2025
@sds
Fix RuboCop check (#196)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
9174196 
This fails with RuboCop running on Ruby 3.4 (see #194).
@sds sds merged commit 2fdbddf into sds:main Mar 3, 2025
0 of 4 checks passed
@sds
Copy link
Owner

sds commented Mar 3, 2025

Thanks!

@sds sds added the enhancement label Mar 3, 2025
@olleolleolle olleolleolle deleted the patch-1 branch March 4, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olleolleolle @sds