fix: in if-needed mode, skip bounds checking for non-scrollable scrollingElement #915
+278
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 3.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lack of proper handling causes scroll to jump unexpectedly when targeting elements that are already in view but outside of the bounding box of the
<html>element in apps that use styles liketo implement e.g. sticky footers
The proposed fix (checking whether
document.scrollingElementis actually scrollable before checking the target element is within its bounds) is consistent with how frames other thandocument.scrollingElementare handled in code and also with the.scrollIntoViewIfNeeded()behavior in Chrome /.focus()in most browsers.A workaround would be to use a more modern approach like
min-height: 100vhon a specific container that needs to stretch to the height of the viewport instead, which is not always possible in legacy apps.