Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zh data #1148

Merged
merged 1 commit into from Mar 7, 2023
Merged

Update zh data #1148

merged 1 commit into from Mar 7, 2023

Conversation

serhii73
Copy link
Collaborator

@serhii73 serhii73 commented Mar 3, 2023

No description provided.

@Gallaecio Gallaecio merged commit 7cd3b80 into master Mar 7, 2023
@RadhiFadlillah
Copy link
Contributor

If you don't mind, I'm wondering why does the modification in this PR are done directly in CLDR JSON file?

From what I understand, those CLDR files are synced periodically with the upstream repo,so it shouldn't be modified. Instead, we should modify the supplemental *.yaml file which later will be merged with the CLDR data.

Is my understanding correct? Or have there been recent changes to the way translations are contributed?

@Gallaecio
Copy link
Member

You are right, we should only be modifying YAML files.

@serhii73 It is probably OK for now, but whenever we update the CLDR JSON files from upstream next, we may need to check if what we added here exists upstream, and if not, we would need to move the data to the YAML files to make sure it is included going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants