Parse Monday #1121
Merged
Parse Monday #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close #1116
Gallaecio
reviewed
Jan 10, 2023
| @@ -97,7 +97,6 @@ def test_relative_past_dates_with_time_as_period(self, date_string, ago, period) | |||
| param('nine hours ago', ago={'hours': 9}, period='day'), | |||
| param('three week ago', ago={'weeks': 3}, period='week'), | |||
| param('eight months ago', ago={'months': 8}, period='month'), | |||
| param('1mon ago', ago={'months': 1}, period='month'), | |||
There was a problem hiding this comment.
Similar to how there is test_insane_dates and test_dates_not_supported_by_date_time, we could add a test_known_issues that keeps this test case around but expects it to fail, and include a comment pointing to the issue that caused us to break it.
(I thought we were using pytest’s parametrize when I suggested marking this line as an expected failure)
Gallaecio
approved these changes
Jan 11, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1116