New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEP: extend some announced deprecations due to out-of-band 1.13 release #19892
Conversation
To summarize, this extends the following deprecation announcements, while keeping the originally intended ~1 year window between deprecation and removal.
In the future we may choose to completely avoid announcing specific versions for removal, but for now I just did a minimal/mechanical update here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @h-vetinari. Looks like the test failure here are real but the rest seems reasonable.
I have been very busy recently so haven't kept up with all the discussions however this seems to match the conclusion of the linked discussion.
I think we should also consider bumping:
scipy/scipy/_lib/deprecation.py
Lines 57 to 63 in 2353b15
message = ( | |
f"`scipy.{sub_package}.{module}.{attribute}` is deprecated along with " | |
f"the `scipy.{sub_package}.{module}` namespace. " | |
f"`scipy.{sub_package}.{module}.{attribute}` will be removed " | |
f"in SciPy 1.13.0, and the `scipy.{sub_package}.{module}` namespace " | |
f"will be removed in SciPy 2.0.0." | |
) |
I did this now, even though I think it's kinda a borderline case in terms of utility IMO 🤷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, all seems in order. Are you ok updating the tracker too?
Yes, was planning to do that |
@h-vetinari thanks for doing this so quickly, and apologies for not having clearer/louder messaging on the timeline |
Implement the plan to delay some deprecations, due to the out-of-band release of 1.13 that was not accounted for when these deprecation warnings were written.
I've also moved the deprecation sections away from the top line of docstrings, because that is read/displayed by lots of tooling (e.g. IDEs), and should still contain the description of the function (even though we want to place the deprecation warning prominently).