Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: 1.12 release notes tweaks #19877

Merged
merged 4 commits into from Jan 13, 2024
Merged

DOC: 1.12 release notes tweaks #19877

merged 4 commits into from Jan 13, 2024

Conversation

dschmitz89
Copy link
Contributor

@dschmitz89 dschmitz89 commented Jan 13, 2024 •
edited

What does this implement/fix?

Fixes a few formatting issues in the release notes, mostly related to very long lines that do not render nicely on the release notes page on Github for example and backtick issues in function/method names.

On top a few minor subjective improvements to the optimize notes:

  • new features should be at the top, so moved isotonic_regression there
  • newton-cg now supporting sparse Hessians is actually an improvement and not a bug fix

@github-actions github-actions bot added the Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org label Jan 13, 2024
@dschmitz89 dschmitz89 added the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Jan 13, 2024
@dschmitz89
Fix typo
bbf6beb 
[docs only]
@lucascolley lucascolley added this to the 1.12.0 milestone Jan 13, 2024
tylerjereddy
tylerjereddy approved these changes Jan 13, 2024
View reviewed changes
Copy link
Contributor

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think there are some net improvements, though some are indeed subjective.

Hopefully it doesn't cause too many merge conflicts when I backport. I'll squash-merge to facilitate backporting.

@tylerjereddy tylerjereddy merged commit e5f2129 into scipy:main Jan 13, 2024
25 of 26 checks passed
@dschmitz89 dschmitz89 deleted the release_notes branch January 13, 2024 21:59
tylerjereddy pushed a commit to tylerjereddy/scipy that referenced this pull request Jan 19, 2024
@dschmitz89 @tylerjereddy
DOC: 1.12 release notes tweaks (scipy#19877)
82dddc5 
* SciPy `1.12.0` release notes formatting improvements
@tylerjereddy tylerjereddy mentioned this pull request Jan 19, 2024
Merged
3 tasks
@tylerjereddy tylerjereddy removed the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerjereddy tylerjereddy tylerjereddy approved these changes

Assignees
No one assigned
Labels
Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dschmitz89 @tylerjereddy @lucascolley