Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC, MAINT: Bump CircleCI Python version to 3.11 #19504

Merged
merged 3 commits into from Nov 14, 2023

Conversation

melissawm
Copy link
Contributor

Reference issue

This is an attempt to fix the docs build - locally I also built the docs successfully with Python 3.10, FYI.

What does this implement/fix?

Fixes #19500

@melissawm melissawm marked this pull request as draft November 10, 2023 14:29
@melissawm melissawm force-pushed the docs-build branch 3 times, most recently from cdcafb9 to 4b2bd54 Compare November 10, 2023 21:16
@tylerjereddy tylerjereddy added Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org maintenance Items related to regular maintenance tasks labels Nov 11, 2023
@tylerjereddy tylerjereddy added this to the 1.12.0 milestone Nov 11, 2023
Copy link
Contributor

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I was able to reproduce the failure locally and fix it with python -m pip install "myst-nb<1.0.0".

myst-nb was released two days ago, so that might be worth a try after the line where we do pip install -r doc_requirements.txt, until "upstream" sorts this out

@melissawm
Copy link
Contributor Author

@tylerjereddy I think you are right and this is similar to another issue we've had in the past. I'll just pin myst for now and will keep investigating later. Thanks

@melissawm melissawm marked this pull request as ready for review November 14, 2023 15:53
@melissawm
Copy link
Contributor Author

Docs build failure is a separate issue (see #19519)

@@ -74,8 +74,9 @@ jobs:
- run:
name: setup Python venv
command: |
pip install numpy==1.23.5 cython!=3.0.3 pybind11 pythran ninja meson
pip install numpy cython!=3.0.3 pybind11 pythran ninja meson
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unpinning NumPy and/or bumping the Python version may be related to the new refguide-check failures, but I don't mind putting this in since the myst-nb pin is needed for now.

You may want to keep an eye on the CI and i.e., re-pin NumPy if that helps with the refguide failures. One nice thing about pinning near the oldest supported NumPy/Python versions is that it mirrors how I build docs at release time, but that's mostly a convenience thing rather than requirement for doc build proper.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh got it, I wasn't sure what the purpose of the pin was. Thanks!

@tylerjereddy tylerjereddy merged commit 20d3047 into scipy:main Nov 14, 2023
12 of 16 checks passed
@tylerjereddy tylerjereddy modified the milestones: 1.12.0, 1.11.4 Nov 17, 2023
tylerjereddy pushed a commit to tylerjereddy/scipy that referenced this pull request Nov 17, 2023
* DOC, MAINT: Bump CircleCI Python version to 3.11

* Add pin for myst-nb on CircleCI config to fix doc build issue

[skip azp] [skip cirrus]
tylerjereddy pushed a commit to tylerjereddy/scipy that referenced this pull request Nov 18, 2023
* DOC, MAINT: Bump CircleCI Python version to 3.11

* Add pin for myst-nb on CircleCI config to fix doc build issue

[skip azp] [skip cirrus]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org maintenance Items related to regular maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: doc build failing
2 participants