New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC, MAINT: Bump CircleCI Python version to 3.11 #19504
Conversation
3416f30
to
890ad32
Compare
cdcafb9
to
4b2bd54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I was able to reproduce the failure locally and fix it with python -m pip install "myst-nb<1.0.0"
.
myst-nb
was released two days ago, so that might be worth a try after the line where we do pip install -r doc_requirements.txt
, until "upstream" sorts this out
@tylerjereddy I think you are right and this is similar to another issue we've had in the past. I'll just pin myst for now and will keep investigating later. Thanks |
4b2bd54
to
0dc0f79
Compare
Docs build failure is a separate issue (see #19519) |
[skip azp] [skip cirrus]
[skip azp] [skip cirrus]
[skip azp] [skip cirrus]
0dc0f79
to
d006c87
Compare
@@ -74,8 +74,9 @@ jobs: | |||
- run: | |||
name: setup Python venv | |||
command: | | |||
pip install numpy==1.23.5 cython!=3.0.3 pybind11 pythran ninja meson | |||
pip install numpy cython!=3.0.3 pybind11 pythran ninja meson |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unpinning NumPy and/or bumping the Python version may be related to the new refguide-check failures, but I don't mind putting this in since the myst-nb
pin is needed for now.
You may want to keep an eye on the CI and i.e., re-pin NumPy if that helps with the refguide failures. One nice thing about pinning near the oldest supported NumPy/Python versions is that it mirrors how I build docs at release time, but that's mostly a convenience thing rather than requirement for doc build proper.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh got it, I wasn't sure what the purpose of the pin was. Thanks!
* DOC, MAINT: Bump CircleCI Python version to 3.11 * Add pin for myst-nb on CircleCI config to fix doc build issue [skip azp] [skip cirrus]
* DOC, MAINT: Bump CircleCI Python version to 3.11 * Add pin for myst-nb on CircleCI config to fix doc build issue [skip azp] [skip cirrus]
Reference issue
This is an attempt to fix the docs build - locally I also built the docs successfully with Python 3.10, FYI.
What does this implement/fix?
Fixes #19500