MAINT: SciPy 1.11.1 backports #18779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nputs (scipy#18754) Also ensure `test_factorial{,2,k}_array_corner_cases` covers 0-dim. inputs correctly Unfortunately, `np.array` will ignore an explicit `ndim=0` request and happily give back a 1-dimensional result without complaint: ``` >>> np.array([1], ndmin=0, dtype=np.int64).ndim 1 ``` This invalidated the original assumptions for these tests. Additionally, we need to take care not to iterate over 0-dim arrays (but also keep the tests with two elements in `content` correct), that n.ravel().ndim == 1 even if n.ndim == 0, and that assert_equal will not distinguish scalars from 0-dim arrays with the same value.
* Fixes scipy#18765 * the offending unuran source file was removed over at scipy/unuran#9, and this PR updates us to point to latest `main` version of submodule (caution: this pulls in a few more commits from `main` we didn't have in original `1.11.0` release) * as noted over there, the (SciPy) testsuite appears to pass just fine when this file is purged, likely because we have `HAVE_DECL_LOG1P` always set, since we require C99, and therefore unuran always uses the version from `math.h` instead of in-house anyway
tylerjereddy
requested review from
person142,
larsoner,
ilayn and
rgommers
as code owners
github-actions
bot
added
scipy._lib
scipy.linalg
scipy.odr
scipy.special
scipy.stats
labels
|
Just to comment - it would be great if #18644 could make it into the next patch release as well. |
|
The only CI failure is or was a known issue on
I agree, this situation is a bit different in the sense that I'm moving a bit faster than usual and only added backports that are already merged. Apologies, but it'll surely be in |
tylerjereddy
merged commit 450d8aa
into
scipy:maintenance/1.11.x
22 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release is happening pretty quickly to deal with a licensing issue.
Backports included:
factorial(..., exact=False)for 0-dim array inputs #18754And updated release notes accordingly. The testsuite seems fine locally, didn't check doc build.