BUG: Fix work array construction for various weight shapes. #18741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-bowhay
added
the
defect
|
AFAICT, all of the failures are from unrelated pieces of code. |
rgommers
added
the
backport-candidate
tylerjereddy
pushed a commit
to tylerjereddy/scipy
that referenced
this pull request
Jun 28, 2023
tylerjereddy
removed
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes gh-18739
What does this implement/fix?
The work array size depends on the shape of the
weweight array, which can be of a wide variety of shapes. The current code assumed it was one particular kind and failed to indexwe.shapecorrectly. This method gets called whenset_job(del_init=1)is called, so it does not show up frequently. This fix takes care of all of the other cases.