Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: interpolate: delay interp2d deprecation and update link #18698

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

j-bowhay
Copy link
Member

@j-bowhay j-bowhay commented Jun 18, 2023

Reference issue

#17356 (comment)

What does this implement/fix?

Delays deprecation by one release as discussed and updates link from gist to new notebook tutorial.

Additional information

@j-bowhay j-bowhay added scipy.interpolate deprecated Items related to behavior that has been deprecated labels Jun 18, 2023
@j-bowhay j-bowhay requested a review from ev-br as a code owner June 18, 2023 20:24
Comment on lines +128 to +129
`https://scipy.github.io/devdocs/notebooks/interp_transition_guide.html
<https://scipy.github.io/devdocs/notebooks/interp_transition_guide.html>`_
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember for talk of using an inter sphinx link but given you can't actually click links here because of the theme I think the URL would be better.

Copy link
Member

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Jake.

@tupui tupui merged commit 813034f into scipy:main Jun 19, 2023
23 of 24 checks passed
@tupui tupui added this to the 1.12.0 milestone Jun 19, 2023
@h-vetinari h-vetinari added the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Jun 19, 2023
@h-vetinari
Copy link
Member

I'm making this a backport-candidate in case there's another round of fixes going in, because this is doc-only and a noticeable improvement of the quality/accuracy of the content.

@tylerjereddy tylerjereddy modified the milestones: 1.12.0, 1.11.0 Jun 22, 2023
tylerjereddy pushed a commit to tylerjereddy/scipy that referenced this pull request Jun 22, 2023
@tylerjereddy tylerjereddy removed the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated Items related to behavior that has been deprecated scipy.interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants