MAINT: SciPy 1.10.1 backports round 2 #18001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The definition of check_malloc takes a size_t argument. Fixes a lto-type-mistatch warning. Related to scipy#16098
…ipy#17800) * MAINT: Fix wrong 'directed' being passed in the tests for shortest path algorithms * BUG: scipy.sparse.csgraph: Fix a bug in FibonacciHeap used for the dijkstra function * TST: PR 17800 revisions to pin down exact test cases --------- Co-authored-by: Tyler Reddy <tyler.je.reddy@gmail.com> Co-authored-by: CJ Carey <perimosocordiae@gmail.com> Co-authored-by: Kai Striega <kaistriega@gmail.com>
Remove unnecessary reset of dist_array during Bellman-Ford weight updates. Add unit test for negative weighted shortest paths. See scipy#14980
* `\U` leads to strings being treated as unicode, hence we escape it with raw strings * Changed bool parameters real bools instead of string `"True"` and `"False"` [wheel build]
tylerjereddy
requested review from
person142,
larsoner,
ilayn and
andyfaff
as code owners
|
Main CI is clean -- the linter failure about a single line being too long is irrelevant, especially on a maintenance branch. Proceeding with wheel build test next. |
* test wheel builds in scipygh-18001 [wheel build]
|
CI is good with wheel builds as well, apart from the usual linting complaint, so in it goes and probably onward with the Perhaps for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After manually scanning through bug fixes that were merged after
1.10.0, and adding a few more to the list, the backports listed below have been included here.I updated
.mailmapas well as I could from a quick glance at folks' GitHub profiles.Although I think we dealt with the 32-bit Debian testing issues with SciPy, I wasn't able to provide the level of supported I wanted to Fedora in this regard just yet (see: #17912 (comment)). I suggest we move forward with
1.10.1nonetheless, at around 30 backports merged now, and perhaps I'll get better at using the Fedora tooling to better support/reproduce in the future.Includes these backports:
powm1overflow errors #17855__config__.py.in#17936TODO: