Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC add "polars" to options of transform in set_output #28875

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

yuanx749
Copy link
Contributor

Reference Issues/PRs

NA

What does this implement/fix? Explain your changes.

Polars is supported in set_output, but it is not depicted in the docstring of FeatureUnion.
In this PR I add the "polars" option and also tweak the docs in other places.

Any other comments?

Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 75c489c. Link to the linter CI: here

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuanx749

@jeremiedbb jeremiedbb enabled auto-merge (squash) April 23, 2024 10:48
@jeremiedbb jeremiedbb merged commit 153e796 into scikit-learn:main Apr 23, 2024
31 checks passed
@yuanx749 yuanx749 deleted the doc-polars branch April 23, 2024 11:20
@YueCastillo
Copy link

set_output(transform='polars') returns a polars dataframe with columns turned into objects (in my case, those columns were originally of type float32).
Casting from such objects is not supported in polars (polars.exceptions.ComputeError: cannot cast 'Object' type).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants