TST change random seed to make graphical lasso test pass #27616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @lesteve since you saw the issue in the last PR that we merged. |
lesteve
approved these changes
Oct 19, 2023
adrinjalali
approved these changes
Oct 19, 2023
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 23, 2023
glemaitre
added a commit
that referenced
this pull request
Oct 23, 2023
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 31, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #27509
I investigated a bit the issue with the
test_graphical_lassos. The test is unstable on ARM64 architecture withrandom_state=0. I did not find a tolerance that would make pass the tests for the 100 first random seeds.I assume that we should dedicate more time on the solvers to understand why they don't converge to the same coefficients.